[No Longer Maintained] Withings Integration

[dman2306]

@richard-brown

This looks like an interesting app

I’ll update the link. It’s not actually something I ever finished up.

@richard-brown

So I edited your device driver to change the order of the attributes Systolic, Diastolic, Pulse, but nothing seems to have affected the order in the Device Driver screen

Hubitat always displays them alphabetically. Drivers don’t have a way to customize this. This would require a Hubitat firmware change.

[JustinL]

@dman2306 can correct me if I’m wrong, but I’m certain that this app already takes the change into account. Looking at the code, it uses the new endpoints associated with the change.

[dman2306]

Yup you're correct, the change was introduced a few months ago.

[JustinL]

Any idea why 2 of my 4 sleep pads would be reporting presence events but not sleep score (in the event log)?

[dman2306]

Anything in logs?

[JustinL]

No, but apparently redoing the authentication steps in the HE app reset things to working order. Strange that it lost its way for only 2 of 4 sensors. All working for now tho, and at least that's the first time it's happened ever.

[JustinL]

It looks like Dominic just put an abbreviated header into each file, either unintentionally or intentionally. There's no license information, just a copyright notice. I'm not sure where that leaves this integration. Does anyone have a way to get in touch with Dominic to see if he can clarify this integration's license status, e.g., under Apache 2.0 so we can continue development?

EDIT: I forked and submitted a pull request on Github to clarify the license status.

[JustinL]

I can’t seem to get any clarification on the license for this integration. Not answering issues or pull requests on GitHub. Anyone else have any ideas? Otherwise this integration is going to lead to a dead end when it needs revising to fix an API change.

[rlithgow1]

@csteele Do you know what @dman2306's position is regarding his apps since you took over HPM?

[thebearmay]

Not a lawyer, but 2 ways I can think to approach this:

1. Use the code as an abandoned work as it is marked “No Longer Maintained”

2. Use it as the source for a derivative work
   a) Would need to acknowledge the original copyright

   b) dman2306 would retain all rights to the original code and may have some rights to the deriviative

[JustinL]

I actually happen to be an IP attorney…without any granting of a license, we can’t do any of that. At least not legally. I saw in one of his posts for HPM that made it sound like he just didn’t even think about a license, so I suspect it is just an oversight on his part. Just proving challenging to get in touch with him.

[thebearmay]

@JustinL

I actually happen to be an IP attorney

There’s the problem …

[JustinL]

@thebearmay

There’s the problem

Ha, at least I’m not chasing ambulances! I just wish I had noticed this license issue earlier. Since using HPM, I haven’t had to even look at the code, so didn’t think about it. Maybe that was his plan all along with HPM

[csteele]

dcmeglio/hubitat-packagemanager/blob/master/LICENSE

[csteele]

[BETA] Hubitat Package Manager

100%. All I can say to that is, can I guarantee I'll maintain my code years from now? No. Can I think of a scenario where I'll take down all of my code? Nope? My reasoning? I'm not 12 The thing with any of these solutions, forking, cloning, anything else really, it's not going to automatically grab changes. So if the original author makes changes, your fork doesn't automatically update those. HPM is released under the BSD license which essentially means you can't change the l…

He did explain his License in the last line of that message. And again:

[BETA] Hubitat Package Manager

Hmm a screenshot would be great, I'm not sure I understand the request so that would help. Nope. That said, I've kind of also made it clear that I'm not really interested in that. At the same time, the code is released under the BSD 3.0 license so as long as they respect that license they'd be free to take my code, change it up, etc. without even telling me.

This is a Withings Topic and I'll note that there's no License added in his Github repo for that code.

[rlithgow1]

As a layman I think that last bit answers @JustinL 's question.

[JustinL]

@rlithgow1

I think that last bit answers @JustinL 's question.

Well, as @csteele suggested, that last bit gives us good insight into Dominic's intent for licensing the HPM app, but isn't dispositive on Dominic's intent for licensing the Withings integration. If I read between the lines, I think Dominic would / will license the Withings integration in the same way as HPM, but he hasn't actually done so yet. Hopefully Dominic will respond to my github pull request / issue soon.

[rlithgow1]

[JustinL]

Heard from Dominic on github. He’s indeed going to apply BSD to this integration as well.

[JustinL]

Dominic just accepted my pull request on GitHub to add the BSD-3 license. So it’s officially open source and able to be maintained by anyone able and willing!