2.3.5.152 seems to have broken my LeakSmart valve - Fixed, Driver issue

StephenH · June 27, 2023, 3:58am

@bravenel @gopher.ny
My LeakSmart valve has been operating without problem for many months. Tonight, I installed the 2.3.5.152 release and my LeakSmart valve closed. When I try to open it, it closes immediately as if there were a leak. I checked all of my sensors, and there is no leak anywhere that would trigger it to close.

Excerpt from HSM log:
app:9402023-06-26 23:43:45.973warnAlert Water canceled
app:9402023-06-26 23:43:43.132infoAll Disarmed
app:9402023-06-26 23:43:29.033infoWater valve: [LeakSmart Valve] closed
app:9402023-06-26 23:43:28.979warnAlert Water LeakSmart Valve wet
app:9402023-06-26 23:26:58.233warnAlert Water canceled
app:9402023-06-26 23:26:30.158infoWater valve: [LeakSmart Valve] closed
app:9402023-06-26 23:26:30.134warnAlert Water LeakSmart Valve wet
app:9402023-06-26 23:22:59.366warnAlert Water canceled
app:9402023-06-26 23:22:43.303infoWater valve: [LeakSmart Valve] closed
app:9402023-06-26 23:22:43.270warnAlert Water LeakSmart Valve wet
app:9402023-06-26 23:16:33.581warnAlert Water canceled
app:9402023-06-26 23:16:19.560infoWater valve: [LeakSmart Valve] closed
app:9402023-06-26 23:16:19.525warnAlert Water LeakSmart Valve wet
app:9402023-06-26 23:16:02.022infoWater valve: [LeakSmart Valve] closed
app:9402023-06-26 23:16:01.987warnAlert Water LeakSmart Valve wet
app:9402023-06-26 23:15:37.405infoWater valve: [LeakSmart Valve] closed
app:9402023-06-26 23:15:37.376warnAlert Water LeakSmart Valve wet
app:9402023-06-26 23:12:22.378infoWater valve: [LeakSmart Valve] closed
app:9402023-06-26 23:12:22.327warnAlert Water LeakSmart Valve wet
app:9402023-06-26 23:01:09.234warnAlert Water canceled
app:9402023-06-26 23:00:58.237infoWater valve: [LeakSmart Valve] closed
app:9402023-06-26 23:00:58.205warnAlert Water LeakSmart Valve wet

Excerpt from LeakSmart valve log:
dev:9112023-06-26 23:47:09.924infoLeakSmart Valve : Received Valve:open Our State:open
dev:9112023-06-26 23:47:07.088infoLeakSmart Valve : Event Valve: open
dev:9112023-06-26 23:47:06.726infoLeakSmart Valve : Opening the valve
dev:9112023-06-26 23:47:04.373infoLeakSmart Valve : Received Valve:closed Our State:closed
dev:9112023-06-26 23:47:01.604infoLeakSmart Valve : Received Valve:closed Our State:closed
dev:9112023-06-26 23:47:01.590infoLeakSmart Valve : Received Valve:closed Our State:closed
dev:9112023-06-26 23:47:01.543infoLeakSmart Valve : Event Valve: closed
dev:9112023-06-26 23:46:55.038infoLeakSmart Valve : Closing the valve
dev:9112023-06-26 23:45:20.420infoLeakSmart Valve : Received Valve:open Our State:open
dev:9112023-06-26 23:45:17.752infoLeakSmart Valve : Received Valve:open Our State:open
dev:9112023-06-26 23:45:17.741infoLeakSmart Valve : Received Valve:open Our State:open
dev:9112023-06-26 23:45:17.700infoLeakSmart Valve : Received Valve:open Our State:open
dev:9112023-06-26 23:45:17.627infoLeakSmart Valve : Event Valve: open
dev:9112023-06-26 23:45:10.953infoLeakSmart Valve : Opening the valve
dev:9112023-06-26 23:43:29.512infoLeakSmart Valve : Event Valve: closed
dev:9112023-06-26 23:43:29.014infoLeakSmart Valve : Closing the valve
dev:9112023-06-26 23:43:28.470infoLeakSmart Valve : Event Valve: open
dev:9112023-06-26 23:43:27.533infoLeakSmart Valve : Opening the valve
dev:9112023-06-26 23:26:54.396infoLeakSmart Valve : Battery Voltage 6.3v Calc 100%
dev:9112023-06-26 23:26:33.084infoLeakSmart Valve : Received Valve:closed Our State:closed
dev:9112023-06-26 23:26:30.337infoLeakSmart Valve : Event Valve: closed
dev:9112023-06-26 23:26:30.146infoLeakSmart Valve : Closing the valve
dev:9112023-06-26 23:26:29.813infoLeakSmart Valve : Event Valve: open
dev:9112023-06-26 23:22:43.518infoLeakSmart Valve : Event Valve: closed
dev:9112023-06-26 23:22:43.468infoLeakSmart Valve : Received Valve:open Our State:open
dev:9112023-06-26 23:22:43.287infoLeakSmart Valve : Closing the valve
dev:9112023-06-26 23:22:42.969infoLeakSmart Valve : Received Valve:open Our State:open
dev:9112023-06-26 23:22:42.943infoLeakSmart Valve : Event Valve: open
dev:9112023-06-26 23:22:39.781infoLeakSmart Valve : Opening the valve
dev:9112023-06-26 23:20:54.854infoLeakSmart Valve : Received Valve:closed Our State:closed
dev:9112023-06-26 23:16:19.799infoLeakSmart Valve : Event Valve: closed
dev:9112023-06-26 23:16:19.539infoLeakSmart Valve : Closing the valve
dev:9112023-06-26 23:16:19.330infoLeakSmart Valve : Received Valve:open Our State:open
dev:9112023-06-26 23:16:19.300infoLeakSmart Valve : Received Valve:open Our State:open
dev:9112023-06-26 23:16:19.260infoLeakSmart Valve : Event Valve: open
dev:9112023-06-26 23:16:15.051infoLeakSmart Valve : Opening the valve
dev:9112023-06-26 23:16:02.203infoLeakSmart Valve : Event Valve: closed
dev:9112023-06-26 23:16:02.006infoLeakSmart Valve : Closing the valve
dev:9112023-06-26 23:16:01.664infoLeakSmart Valve : Event Valve: open
dev:9112023-06-26 23:16:01.254infoLeakSmart Valve : Opening the valve
dev:9112023-06-26 23:15:37.619infoLeakSmart Valve : Event Valve: closed
dev:9112023-06-26 23:15:37.390infoLeakSmart Valve : Closing the valve
dev:9112023-06-26 23:15:37.162infoLeakSmart Valve : Received Valve:open Our State:open
dev:9112023-06-26 23:15:37.133infoLeakSmart Valve : Received Valve:open Our State:open
dev:9112023-06-26 23:15:37.082infoLeakSmart Valve : Event Valve: open
dev:9112023-06-26 23:15:33.451infoLeakSmart Valve : Opening the valve
dev:9112023-06-26 23:12:22.877infoLeakSmart Valve : Event Valve: closed
dev:9112023-06-26 23:12:22.360infoLeakSmart Valve : Closing the valve
dev:9112023-06-26 23:12:21.895infoLeakSmart Valve : Received Valve:open Our State:open
dev:9112023-06-26 23:12:21.879infoLeakSmart Valve : Event Valve: open
dev:9112023-06-26 23:12:19.671infoLeakSmart Valve : Opening the valve
dev:9112023-06-26 23:10:54.777infoLeakSmart Valve : Received Valve:closed Our State:closed
dev:9112023-06-26 23:01:01.386infoLeakSmart Valve : Received Valve:closed Our State:closed
dev:9112023-06-26 23:00:58.475infoLeakSmart Valve : Event Valve: closed
dev:9112023-06-26 23:00:58.225infoLeakSmart Valve : Closing the valve
dev:9112023-06-26 23:00:57.899infoLeakSmart Valve : Event Valve: open
dev:9112023-06-26 23:00:54.964infoLeakSmart Valve : Event Valve: closed

I reverted to 2.3.5.146 and the LeakSmart valve is staying open and not triggering an alert. This is a big problem.

jameslslate · June 27, 2023, 4:00am

Mine is working fine. Does your valve have this info?

bravenel · June 27, 2023, 4:17am

Roll back to previous release and see if that fixes it or not.

StephenH · June 27, 2023, 4:17am

endpointId: 01
application: 1D
firmwareMT: 113B-03E8-0000001D
inClusters: 0000,0001,0003,0004,0005,0006,0020,0B02,FC02
manufacturer: WAXMAN
model: House Water Valve - MDL-TBD
outClusters: 0003,0019
softwareBuild: 0000001D

I did roll back and it is working properly now.

bravenel · June 27, 2023, 4:21am

Please show a screenshot of the HSM setup page.

Is this a Custom Rule child?

Also, I need to know how you are controlling this. Rules? Manually from device page? From the HSM page? I don't have enough information about the context.

StephenH · June 27, 2023, 4:32am

No, it is not a custom rule child.

HSM_Water_alert

Hopefully, this is what you meant about the HSM setup page. I copied the Water section as to try to copy the whole page would have taken multiple screenshots.

bravenel · June 27, 2023, 4:40am

Do you have both RM and HSM using the same leak detector and taking the same action?

For whatever device it is that is the leak detector, please post a screenshot of the Events from its device page. Click on the Events button at the top, and post the page that comes up.

I don't know anything about your setup, so it's not obvious what's going on. What is opening the valve right after it closes? What device is reporting a leak? Turn on Event Logging for that rule.

If you're going to post any more logs, please use screenshots, not copy/paste.

StephenH · June 27, 2023, 4:53am

Okay, it is not that something is opening the valve after it closes, but the opposite. I had opened the valve and it shut immediately. This happened several times until I reverted back to 2.3.5.146. This problem started this evening when I did the upgrade to 2.3.5.152. Before then, I had no problem. Reverting back to 2.3.5.146 restored the expected behavior.

On June 2nd, I did have one sink sensor get wet when I dripped some water on it. It showed wet, then dry. After that, there were only battery level reports. None of the other leak sensors show any leak detected. The only thing in the events listing for all except the one are battery level reports.

Which would be the preferred method to control the valve, Rule or HSM? I can eliminate the less desirable method.

jameslslate · June 27, 2023, 5:00am

I use HSM to shut off the valve, and a Basic Rule to open it again when all sensors report dry.

bravenel · June 27, 2023, 5:06am

I'm just trying to figure out what is causing this, that might be in 2.3.5.152 but not earlier releases. There were minor, mostly cosmetic changes to HSM, but nothing that would explain this.

Your logs show something tripping HSM with wet, after which it closes the valve, but whatever is reporting wet continues to do so. Is there a leak sensor called "LeakSmart Valve"? So we need to find what device is throwing the wet event.

StephenH · June 27, 2023, 5:14am

LeakSmart Valve is just that. It is the shut-off valve. It is not a sensor, so when it reports wet, that means it is open. When it reports dry, it is closed.

I looked and HSM looked to be treating the LeakSmart Valve as a sensor. I unchecked the option to use all sensors and instead, selected the leak detectors. The Water section of HSM now looks like this:

HSM_modified

Also, since my rule and HSM are accomplishing the same thing, I paused my rule. I will probably eliminate the rule and just let HSM handle the valve.

kkossev · June 27, 2023, 5:25am

The valve driver should not expose "WaterSensor" capability... just "Valve" (open/closed).

StephenH · June 27, 2023, 5:32am

The driver I am using is the one from here:

github.com

tmastersmart/hubitat-code/blob/main/leaksmart-water-valve.groovy

/**
   Hubitat LeakSmart Water Valve driver for hubitat
   Hubitat Iris Water Valve driver
   with mains detection,Appliance Alerts,Test system,
   Test schedule.

   leaksmart driver hubitat 

 _                _    _____                      _     _   _       _           
| |              | |  /  ___|                    | |   | | | |     | |          
| |     ___  __ _| | _\ `--. _ __ ___   __ _ _ __| |_  | | | | __ _| |_   _____ 
| |    / _ \/ _` | |/ /`--. \ '_ ` _ \ / _` | '__| __| | | | |/ _` | \ \ / / _ \
| |___|  __/ (_| |   </\__/ / | | | | | (_| | |  | |_  \ \_/ / (_| | |\ V /  __/
\_____/\___|\__,_|_|\_\____/|_| |_| |_|\__,_|_|   \__|  \___/ \__,_|_| \_/ \___|



LeakSmart Valve FCC ID: W7Z-ZICM357SP2

tested on firmware

This file has been truncated. show original

jameslslate · June 27, 2023, 5:32am

What driver are you using?

jameslslate · June 27, 2023, 5:34am

I'm using this one.

/**

LeakSMART Water Valve v 1.3
```
(Mode: 8830000L)
```
Capabilities:

 Configuration, Refresh, Switch, Valve, Polling

Author:
```
Kevin LaFramboise (krlaframboise)
```
Url to Documentation:

 https://community.smartthings.com/t/release-leaksmart-water-valve/48669

jameslslate · June 27, 2023, 6:09am

Just for giggles, I changed my driver to the one you are using. It would not even close the valve. Changed back to the one I was using originally, and the valve closes and opens as it should.

aaiyar · June 27, 2023, 12:55pm

To add to the confusion, I am using an older (modified) version (version 2.9) of the same driver as @StephenH. The changes I made to version 2.9 seem to be very similar to those present in version 3.0 of this driver.

And my valve is controlled perfectly on 2.3.5.152, as well as older platform releases. The device info for my valve looks like yours.

When you changed drivers, did you click "Configure"?

Screenshot 2023-06-27 at 7.47.35 AM

StephenH · June 27, 2023, 12:56pm

The one I am using was a fork of the smartthings one by Kevin, to modify it for Hubitat. It was working fine. I think the title should have been that the 2.3.5.152 exposed a problem with the driver in that it started treating the valve as a sensor.

aaiyar · June 27, 2023, 12:59pm

Yes, as @kkossev pointed out, the issue at hand is that this driver from @iris exposes the valve as a sensor. I concur with @kkossev that capability should not be exposed in a valve, so I had removed that in the slightly modified version that I use.

StephenH · June 27, 2023, 1:13pm

Is it just removing the capability "Water Sensor" on line 138?