What is the best way to submit patches

🚧 Developers
1

I would like to start with a heartfelt thank you to all those who have created and contributed drivers and other code for the Hubitat, and I include drivers and code that I don't use.

My Hubitat installation, and the devices that it's working with is rather new, and there will be more devices added in the coming weeks (we bought individual samples of the devices that we want to include in our setup, in order to experiment before committing to buying larger numbers)

I've been working specifically with the Sinopé TH1123ZB thermostats, and I must express gratitude specifically to "scoulombe", "kris2k2", and "samuel.c.auclair" for the work they have done to improve upon the default Hubitat driver for this device (and its 4000 Watt sibling). With what I believe is the latest version of samuel.c.auclair's "Thermostat TH112xZB with energy meter" driver, (and the "Virtual outdoor conditions" driver), I have been able to move ahead with my setup and get the information that I want.

In particular, I really like the energy monitoring from the thermostat driver, but I still wanted the "state change" logging that the built-in driver gives us. I intend to use those logs to create graphs of on-time of the baseboard heaters, which I will correlate to the energy consumption information provided by the driver. Also, for the benefit of being able to easily see in the log which thermostat is reporting a particular log entry (and similarly for the "Virtual outdoor conditions" driver, in case someone were to use multiple instances of it, though I can't think of a reasonable use case for that but in the interest of consistency ...), I adjusted the logging to use the ${device.displayName} variable.

What I would like to do now is submit these changes (I'm presuming in the form of a patch) to Samuel, so that he can (if he deems appropriate) incorporate them into the driver for the benefit of others. Although I do have a github account, I don't really use it, and I don't particularly want to fork the repositories for these drivers into my own. The changes I've made and am proposing to submit are not sufficient (in my opinion) to have yet another code base for this driver. It's really just minor patching to the great work that Samuel, "kris2k2", and "scoulombe" have already done.

Samuel, if there's a way for me to contact you, either in the forum here, or otherwise, in order to submit these patches for your code, please let me know and I will get the patches to you, and of course, merci encore pour tout ton travaille.

2 Likes
2

Great to see you having a good experience with the platform and with fellow developers here on the Community.

If you are wanting to get in touch with the developer's, I would suggest one of the following:

  • If there is a topic here on the Community for the drivers or app you are interested in, it is common for users to post questions or requests on that topic, as it notifies the developer, users of the driver or app can read about experiences of other users and even offer assistance. This is often the preferred option
  • If you are posting in a new topic, like this one, tagging the user will mean they will be notified that you have a question or something you want them to know
  • You could also send someone a personal message here on the Community
  • There are also avenues to get in touch with people via GitHub, often by raising an Issue, depending on the setup of the repository

Sorry if I'm telling you things you already know...

3

Thanks. Since I've already created this as a new topic, and it refers to more than one driver discussed in the Apps and Drivers forum, I think I should probably try to tag the developers I mention. I'll take a moment to make sure I get their usernames correct, of course.

1 Like
4

Are you the same person as the OP? Looks like you are using two different usernames here on the Community..... Perhaps you are posting from different devices that are logged in under different user names?

5

Yes, that's me. I posted the original message before setting up my profile. The view I have does show the username updated (after I adjusted my profile) on the original post. Is that not what you see?

6

Ah, I see now, yes, I must have been seeing a cached version of your OP. Once I went out of the topic and back in it is all good now.

7

Excellent. Thanks for checking and confirming.

1 Like
8

For the benefit of tagging the author of the drivers to which I'm referring, @samuel.c.auclair, @kris2k2, @scoulombe, and @mike.maxwell, because I believe that he developed the built-in Sinopé TH1123ZB Hubitat driver, thank you all for your work on this. Please see my original post in this thread. I'd like to submit some patches to you.

2 Likes
9

I also wouldn't be shy about suggesting a change via github pull requests and then stating in the app community thread here what your proposed change is and why. Even if they don't accept it, it helps other users of the apps/drivers to see the edits which they could do locally as well.

this is how I started my contributions

2 Likes
10

I might go that route, but all I really have done is added to the logging, so it really doesn't seem worthwhile to create yet another code-base for it. Still if @samuel.c.auclair isn't around these days to receive my patch, that might be the way to go... Thanks for commenting.

2 Likes
11

From time to time, when I'm tag, I'm still around. You can write me in private so I could integrate your improvement. However, I will must likely be slow, I have too much things going on and other side project.

2 Likes
12

Excellent. It'll probably be a few days before I get back to you anyway, for the same reasons. You can expect to hear from me perhaps mid-week next week.