Does VLD really need to subscribe to EVERY location event? Why not just location.mode events? That has to be why VLD is chewing up so much CPU also...I would just fix this, but the code is not super clear to me....
Whose app code are you using for this? This would be a good question for whoever wrote/ported this particular version. The one by nhschottfam that also appears to be in HPM (there may be others with the same name, so not saying this is the only one it could be) is one I found with a quick search and does appear to subscribe only to location mode events in the equivalent line of code, as you suggest:
I was using the code from here. There doesn't seem to be a central Vacation Lighting Director thread in the HE forums, so not even sure where I got it from. But you're right, the one in HPM is the way to go. Thanks for pointing me to it.
If you or anyone else interested, here is the original port from the Smart Things platform back in the day by one of the original users of Hibitat. Just uploaded it to my GitHub page.