'Porch Lights' is a scene. Currently it just contains one device (a switch that controls the garage side lights). I verified when I manually activate / deactivate this scene, the lights are controlled properly.
A comment on the rule structure. The Wait for event and Off are common to both the IF and ELSE-IF. You can rewrite with one IF-THEN or a Simple Condition.
IF (Porch Lights is off) THEN
On: Porch Lights
END-IF
Wait for event: When time is 11:00 PM
Off: Porch Lights
For some reason... tonight the task worked as it should have and the lights turned off properly. Not sure what was different about tonight vs the past couple of nights, but I'll keep an eye on it for the next few days.
Building on a previous reply you donāt need the if statement at all. Just three simple statements: turn on, wait, turn off. If the light is already on then sending another on command isnāt going to do any harm.
One more thing to consider. I don't use scenes much, but turning a scene off is not the same as turning a device off. Your scene may have a different setting for what happens when an off command is received...