I have three Legacy Rules that monitor doors being left open. They have not been modified in years but are throwing errors. I don't know exactly when the errors began (because they only occur when a door is actually left open and Logs have a finite retention period) but my intuitive is a hub update is the cause. I'm currently running v2.3.5.152 on a C-7.
If the rule isn't working as expected (i.e., if the error is causing an actual problem), I'd try re-creating it in the latest Rule Machine. Note that you can pause Legacy rules in 5.x but not vice versa, so depending on where the error is, you may be able to get away with doing one or need to do both.
I'm assuming Legacy is unlikely to receive additional attention at this point.
Should be the same way as it was set up before, a simple conditional (not a full "if expression then") with a repeat chosen as the action.
But on a related note, there are now more ways to create repeats, including "while," so you may be able to find a different/better way. I'm not sure how this one is stopped (that appears to be broken in your screenshot, perhaps a deleted device or variable), but they are a newer option.
Can you change your Delays to Waits and see if it works? Also, you're setting a lot of things within the repeat that probably only need to be set once - unless you have conflicting rules that'll change the sink light or the AVR. Perhaps that'll help eliminate or combine some Delays/Waits.
I think that means you have a repeat action already and it won't allow you to put a repeat within a repeat. If it's still there, delete the broke repeat first.
I don't think you need to check if the pantry is open to start the repeat. You've already established that the pantry is open when the rule was triggered. If it's closed then your second rule will stop this rule from running. Try the repeat without the simple condition and see if it works.
I don't believe there is any intention to provide an update to 2.3 beyond .5.152. If deleting and recreating the action work then great! If not then I suggest you considered deleting the Simple Condition and see if that works as checking for Pantry open is redundant.
If you believe this to be the case, you have the option to go back to the last few installed builds/versions on your hub and the ability to make the latest build of any of at least the last few versions available there as well. Rolling back would show if it worked or not.
But Rule Machine Legacy has not been touched in probably years at this point, so an update breaking something would not be my first suspicion. More likely, something else broke the rule, maybe a device or variable you removed without checking the rule. A backup or re-creating the affected actions would be the solution there--or just re-creating the rule in 5.1 if you're going to re-do anything sinxe you would get support if there is a demonstrable problem there.
I found a duplicate of the receiver device being used in these rules. Renamed the duplicate to BAD. Verified the rules were using the good device and not the BAD device. Deleted the BAD device only to have it magically reappear!
Consider downloading a backup and doing a restore of that backup (no need to do a soft reset in between, though you'll have seen that recommended in the past sometimes too--the restore does one, so no need, the idea in either case being to do some "clean up" on the database if that is the problem). If you are not sure how to do this, see: How to Troubleshoot Apps or Devices | Hubitat Documentation.
I'd also make sure that the device did, in fact, reappear, or that something expected isn't causing it. A couple things could be going on. Rules may show an old/cached name unless (at least) the page is reloaded, so make sure that wasn't the only evidence. Second, are these child devices of some parent integration app (or device)? If so, that app may be re-creating the device. It's hard to say anything without knowing more about the device and your setup.