Latest 2.2.5 break lgk sendmail v2

As reported in beta bodies of email are missing even though logs show them going out correctly.

logs look like this.. everything ok.. but email comes up like this..

As noted previously in the beta, I am experiencing the same issue.

also there are more issues.. something broke the queing.. the state variables being set inside the mutex are not set correctly when one instance runs and another starts up at the same time.. see the following.. this was working in 2.2.3 and 2.2.4

note how it says set last command to initialconnect but immediaately another another instance starts up and it is still getting the value of the last value it was set to "sent ok" this should not be possible..

i believe i have fixed the blank mail issue.. as i summized something in the telnet libraries is stripping off carriage returns or line feeds or both.. i believe smtp needs crlfcrlf to terminate the message..

ie changed this

 def sndMsg =[
        		"MAIL FROM: ${From}"
        		, "RCPT TO: ${To}"
        		, "DATA"
        		, "From: ${From}"
        		, "To: ${To}"
        		, "Subject: ${emlSubject}"
        		, "Date: ${emlDateTime}"		
        		, ""
        		, "${emlBody}"
        		, ""
        		, "."
	        	, "quit"
            ]  

to this

 def sndMsg =[
        		"MAIL FROM: ${From}"
        		, "RCPT TO: ${To}"
        		, "DATA"
        		, "From: ${From}"
        		, "To: ${To}"
        		, "Subject: ${emlSubject}"
        		, "Date: ${emlDateTime}"		
        		, "\r\n"
        		, "${emlBody}\r\n"
        		, "\r\n"
        		, "."
	        	, "quit"
            ]  

new version 2.5.8 on github.. test it and see

still issue the the state variables though not being set correctly so multiple messages not getting put in the queue so will be dropped .

i am guessing it is striping off blank lines.. and that is what caused the issue.

2 Likes

happy side note 2.2.5 appears to have fixed delays with ecolink contact sensors :slight_smile:

2 Likes

Your update fixed LGK Sendmail v2 email send for me as well! Woot! Thanks for tracking down what changed in 2.2.5 and providing a quick patch for the missing body.

Hopefully HE can help w/understanding why state variables aren't working as expected.

1 Like

This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.