So I haven't really added any new stuff really to my setup in a while, and since then Rule Machine 5.1 and a new button controller app have come out. I'm trying to re-create this old Rule Machine legacy in one of the new apps but cannot figure it out.
I can't figure out how to have just if button 1 is pushed do this, or if button 1 is held do this in the new RM. So then I tried the Button Controller App, and I can kind of get there but it looks like the "capture device/restore device" doesn't work between two button rules? Restore is going to "null".
It looks like in the old rule you are capturing and restoring individual devices and now it looks like you’re trying to capture and restore a group, is that correct?
Also, there is no reason to rebuild a rule machine legacy rule that is working. If you want it to function exactly as it was, I would just leave it alone if it’s working. You are not going to gain any advantage.
In terms of your question about RM, I am not sure what you are asking... Unless the screenshot you are showing is from the older RM App, the Actions section of the rule splits out the actions to perform into:
"Select Actions for button 1 pushed"
...
and
...
"Selection Actions for button 1 held"
...
Your questions around Button Controller certainly seem valid in that the Restore Action is null. Did you also try to clone / import this from the old RM Rule? Perhaps try re-creating it from scratch?
And while I agree with @SmartHomePrimer , if it ain't broke, you don't need to fix it, I can understand wanting to keep pace with more recent versions of the platform and wanting to make sure things are working the way they should.
I have a mild OCD too. We justify it by saying we want to make things that are already working like they should, work like they should. 
